Fix: Set media viewers' settings menu dimensions with javascript #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyjin
reviewed
May 16, 2017
src/lib/viewers/media/Settings.js
Outdated
| this.settingsEl.style.width = `${menu.offsetWidth + 18}px`; | ||
| // height = n * $item-height + 2 * $padding (see Settings.scss) | ||
| // where n is the number of displayed items in the menu | ||
| const sumHeight = [].reduce.call(menu.children, (sum, child) => { return sum + child.offsetHeight; }, 0); |
There was a problem hiding this comment.
What Jeremy mentioned in the other review - no need for { } or returns here.
const sumHeight = [].reduce.call(menu.children, (sum, child) => sum + child.offsetHeight, 0);
tonyjin
reviewed
May 16, 2017
src/lib/viewers/media/Settings.js
Outdated
| * Set the menu dimensions depending on which menu is being shown | ||
| * | ||
| * @private | ||
| * @param {Element} menu - The menu/submenu to use for sizing the container |
tonyjin
approved these changes
May 16, 2017
This fixes a bug for when the localized items in the menu would not fit in the menu's fixed width size set by CSS. This will also pave the way for adding more dynamic submenus, e.g. when there are a variable number of subtitles or audio tracks. We could have made the width/height dynamically adjust using width=auto or height=auto. But then CSS transitions don't work. So I resort to a small amount of javascript in this commit to adjust dimensions dynamically. Also, in order to have labels and values all be vertically aligned as a column, I use CSS to give a table layout (display: table). This brings an additional advantage for screen-readers - the label text (e.g. SPEED) is no longer seen as in-line with the value (e.g. Normal), so screen-readers will read them as separate words.
tonyjin
approved these changes
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug for when the localized items in the menu would not fit
in the menu's fixed width size set by CSS. This will also pave the way
for adding more dynamic submenus, e.g. when there are a variable number
of subtitles or audio tracks.
We could have made the width/height dynamically adjust using width=auto
or height=auto. But then CSS transitions don't work. So I resort to
a small amount of javascript in this commit to adjust dimensions
dynamically. Also, in order to have labels and values all be vertically
aligned as a column, I use CSS to give a table layout (display: table).
This brings an additional advantage for screen-readers - the label text
(e.g. SPEED) is no longer seen as in-line with the value (e.g. Normal),
so screen-readers will read them as separate words.